js_stateful-object solution #2704
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBodnar
suggested changes
Aug 9, 2023
src/transformState.js
Outdated
Comment on lines
9
to
11
| const actionType = action.type; | ||
| const actionExtraData = action.extraData; | ||
| const actionKeysToRemove = action.keysToRemove; |
There was a problem hiding this comment.
don't see any sense to create these redundant constants
src/transformState.js
Outdated
Comment on lines
13
to
26
| if (actionType === 'addProperties') { | ||
| Object.assign(state, actionExtraData); | ||
| } | ||
|
|
||
| if (actionType === 'removeProperties') { | ||
| for (const property of actionKeysToRemove) { | ||
| delete state[property]; | ||
| } | ||
| } | ||
|
|
||
| if (actionType === 'clear') { | ||
| for (const element in state) { | ||
| delete state[element]; | ||
| } |
There was a problem hiding this comment.
it's better to use a switch case statement when you have multiple conditions
VitaliyBodnar
suggested changes
Aug 11, 2023
|
|
||
| switch (actionType) { | ||
| case 'addProperties': | ||
| Object.assign(state, action.extraData); |
There was a problem hiding this comment.
you modified initial state, it's a bad idea
you need to create a clone of the state and modify this cloned object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.