Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task solution #2707

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZadorozhnyiYevhenii
Copy link

No description provided.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code

Comment on lines 8 to 9
for (const action of actions) {
switch (action.type) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a destructuring for action

// write code here
for (const action of actions) {
switch (action.type) {
case 'addProperties':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a variables for these magic words and use it everywhere

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants