Solution #2714
Open
Solution #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBodnar
suggested changes
Sep 18, 2023
src/transformState.js
Outdated
Comment on lines
9
to
27
| if (action.type === 'addProperties') { | ||
| const extraData = action.extraData; | ||
|
|
||
| for (const key in extraData) { | ||
| state[key] = extraData[key]; | ||
| } | ||
| } else if (action.type === 'removeProperties') { | ||
| const keysToRemove = action.keysToRemove; | ||
|
|
||
| for (const key of keysToRemove) { | ||
| if (state.hasOwnProperty(key)) { | ||
| delete state[key]; | ||
| } | ||
| } | ||
| } else if (action.type === 'clear') { | ||
| for (const key in state) { | ||
| delete state[key]; | ||
| } | ||
| } |
There was a problem hiding this comment.
- please use the switch case statement here
- move 'addProperties', 'removeProperties', 'clear' to the constants as it will make a code cleaner
src/transformState.js
Outdated
Comment on lines
16
to
18
| const keysToRemove = action.keysToRemove; | ||
|
|
||
| for (const key of keysToRemove) { |
There was a problem hiding this comment.
redundant variable
please check other places
Suggested change
| const keysToRemove = action.keysToRemove; | |
| for (const key of keysToRemove) { | |
| for (const key of action.keysToRemove) { |
mvjl000
suggested changes
Oct 31, 2023
src/transformState.js
Outdated
Comment on lines
8
to
10
| const add = 'addProperties'; | ||
| const remove = 'removeProperties'; | ||
| const clear = 'clear'; |
There was a problem hiding this comment.
Variable names like this are typically uppercase
Suggested change
| const add = 'addProperties'; | |
| const remove = 'removeProperties'; | |
| const clear = 'clear'; | |
| const ADD = 'addProperties'; | |
| const REMOVE = 'removeProperties'; | |
| const CLEAR = 'clear'; |
src/transformState.js
Outdated
Comment on lines
16
to
18
| for (const key in action.extraData) { | ||
| state[key] = action.extraData[key]; | ||
| } |
There was a problem hiding this comment.
You could avoid a nested loop here by using Object.assign
mbruhler
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Approved.
Object.assign is cool but more modern way to achieve the same this is using destructuring
More here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax
It's just a note
|
Thank you, this is a valuable tip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.