add solution #2749
Open
add solution #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viktor-Kost
suggested changes
Mar 11, 2024
src/transformState.js
Outdated
| @@ -5,7 +5,29 @@ | |||
| * @param {Object[]} actions | |||
| */ | |||
| function transformState(state, actions) { | |||
| // write code here | |||
| for (const obj of actions) { | |||
There was a problem hiding this comment.
use more meaningful variable names
Suggested change
| for (const obj of actions) { | |
| for (const action of actions) { |
src/transformState.js
Outdated
| @@ -5,7 +5,29 @@ | |||
| * @param {Object[]} actions | |||
| */ | |||
| function transformState(state, actions) { | |||
| // write code here | |||
| for (const obj of actions) { | |||
| if (obj.type === 'addProperties') { | |||
src/transformState.js
Outdated
Comment on lines
10
to
12
| for (const i in obj.extraData) { | ||
| state[i] = obj.extraData[i]; | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (const i in obj.extraData) { | |
| state[i] = obj.extraData[i]; | |
| } | |
| Object.assign(state, action.extraData); |
SanyaBratashchuk
approved these changes
Mar 12, 2024
| break; | ||
|
|
||
| case 'removeProperties': | ||
| for (const i of action.keysToRemove) { |
There was a problem hiding this comment.
Suggested change
| for (const i of action.keysToRemove) { | |
| for (const key of action.keysToRemove) { |
| break; | ||
|
|
||
| case 'clear': | ||
| for (const i in state) { |
There was a problem hiding this comment.
Suggested change
| for (const i in state) { | |
| for (const key in state) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.