Solution #4837
Open
Solution #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jion353
approved these changes
Oct 28, 2024
src/calculateRentalCost.js
Outdated
| const getOff3days = 20; | ||
| let totalCost = rentCostForOneDay * days; | ||
|
|
||
| if (days >= 7) { |
There was a problem hiding this comment.
краще використати константу замість простого числа, так само і до наступного )
BudnikOleksii
suggested changes
Oct 30, 2024
src/calculateRentalCost.js
Outdated
Comment on lines
7
to
11
| const rentCostForOneDay = 40; | ||
| const LONG_TERM_DISCOUNT = 50; | ||
| const SHORT_TERM_DISCOUNT = 20; | ||
| const LONG_TERM = 7; | ||
| const SHORT_TERM = 3; |
There was a problem hiding this comment.
All constants should be in UPPER_CASE and move them outside the function
src/calculateRentalCost.js
Outdated
Comment on lines
12
to
18
| let totalCost = rentCostForOneDay * days; | ||
|
|
||
| if (days >= LONG_TERM) { | ||
| totalCost -= LONG_TERM_DISCOUNT; | ||
| } else if (days >= SHORT_TERM) { | ||
| totalCost -= SHORT_TERM_DISCOUNT; | ||
| } |
There was a problem hiding this comment.
Suggested change
| let totalCost = rentCostForOneDay * days; | |
| if (days >= LONG_TERM) { | |
| totalCost -= LONG_TERM_DISCOUNT; | |
| } else if (days >= SHORT_TERM) { | |
| totalCost -= SHORT_TERM_DISCOUNT; | |
| } | |
| const totalCost = rentCostForOneDay * days; | |
| if (days >= LONG_TERM) { | |
| return totalCost - LONG_TERM_DISCOUNT; | |
| } | |
| if (days >= SHORT_TERM) { | |
| return totalCost - SHORT_TERM_DISCOUNT; | |
| } |
Prefer if with return over if else to simplify later conditions.
BudnikOleksii
approved these changes
Oct 31, 2024
| @@ -3,8 +3,24 @@ | |||
| * | |||
| * @return {number} | |||
| */ | |||
| const RENTCOSTFORONEDAY = 40; | |||
There was a problem hiding this comment.
Suggested change
| const RENTCOSTFORONEDAY = 40; | |
| const RENT_COST_FOR_ONE_DAY = 40; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.