Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #4841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #4841

wants to merge 1 commit into from

Conversation

nataliia2211
Copy link

No description provided.

taniabarkovskya
taniabarkovskya approved these changes Oct 28, 2024
View reviewed changes
Copy link

@taniabarkovskya taniabarkovskya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! You can be proud of yourself 🌺

src/calculateRentalCost.js
const RENT_A_DAY = 40;

if (days < SHORT_TERM) {
return days * RENT_A_DAY;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можна додатково винести days * RENT_A_DAY в окрему змінну для зручності та щоб уникнути повторень в даному коді :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можна додатково винести days * RENT_A_DAY в окрему змінну для зручності та щоб уникнути повторень в даному коді :)

Good point

BudnikOleksii
BudnikOleksii approved these changes Oct 29, 2024
View reviewed changes
Copy link

@BudnikOleksii BudnikOleksii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍
Approved, but check the comment

src/calculateRentalCost.js
const RENT_A_DAY = 40;

if (days < SHORT_TERM) {
return days * RENT_A_DAY;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можна додатково винести days * RENT_A_DAY в окрему змінну для зручності та щоб уникнути повторень в даному коді :)

Good point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BudnikOleksii BudnikOleksii BudnikOleksii approved these changes

@taniabarkovskya taniabarkovskya taniabarkovskya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nataliia2211 @BudnikOleksii @taniabarkovskya