Solution #4848
Open
Solution #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jion353
approved these changes
Oct 28, 2024
BudnikOleksii
suggested changes
Oct 29, 2024
src/calculateRentalCost.js
Outdated
Comment on lines
7
to
11
| const PRICE_PER_DAY = 40; | ||
| const LONG_TERM = 7; | ||
| const SHORT_TERM = 3; | ||
| const BIG_DISCOUNT = 50; | ||
| const SMALL_DISCOUNT = 20; |
There was a problem hiding this comment.
Move constants outside the function
src/calculateRentalCost.js
Outdated
| const SMALL_DISCOUNT = 20; | ||
|
|
||
| if (days >= LONG_TERM) { | ||
| return days * PRICE_PER_DAY - BIG_DISCOUNT; |
There was a problem hiding this comment.
You do days * PRICE_PER_DAY 3 times, create a variable
BudnikOleksii
approved these changes
Oct 31, 2024
| function calculateRentalCost(days) { | ||
| // write code here | ||
| const PRICE = days * PRICE_PER_DAY; |
There was a problem hiding this comment.
Suggested change
| const PRICE = days * PRICE_PER_DAY; | |
| const currentPrice = days * PRICE_PER_DAY; |
Variable names should be in camelCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.