-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #4850
base: master
Are you sure you want to change the base?
Solution #4850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your implementation of the calculateRentalCost
function looks great! 🎉 You've done a fantastic job using descriptive names and avoiding hardcoding, which makes your code clear and maintainable. Just double-check that the discount conditions align perfectly with the task requirements. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
||
if (days < shortTerm) { | ||
return days * basePrice; | ||
} else if (days < longTerm) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the condition days < longTerm
correctly reflects the task requirements for applying the small discount. If the task specifies different conditions for discounts, adjust this logic accordingly.
return days * basePrice; | ||
} else if (days < longTerm) { | ||
return days * basePrice - smallDiscount; | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the condition for applying the big discount aligns with the task requirements. If the task specifies a different threshold or condition, update this logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🎉 Your implementation of the calculateRentalCost
function is spot on and meets all the task requirements. The use of descriptive variable names and constants enhances readability and maintainability. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
No description provided.