task calculateRentalCost #4871
task calculateRentalCost #4871
Conversation
There was a problem hiding this comment.
Your code meets the task requirements and is functionally correct! 🎉 The only minor issue is the variable naming convention, where TermDiscount should be renamed to termDiscount to follow JavaScript's camelCase convention. Additionally, consider simplifying your discount logic by removing redundant conditions. Keep up the great work, and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| const basePriceOfDay = 40; | ||
| const longTerm = 7; | ||
| const longTermDiscount = 50; | ||
| const TermDiscount = 20; |
There was a problem hiding this comment.
The variable TermDiscount should be consistently named. Consider renaming it to shortTermDiscount to match the naming convention of longTermDiscount.
| } else if (days < longTerm) { | ||
| return basePrice - TermDiscount; |
There was a problem hiding this comment.
The condition days < longTerm is redundant here because it is already covered by the else block. Consider simplifying the logic by removing this else if block and directly applying the short-term discount for days between 3 and 6.
CHECKLIST