Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #5077

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PavloYurievich
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the calculateRentalCost function! 🎉 The logic for calculating the rental cost and applying discounts is spot on. There are just a couple of minor spelling errors in your constant names: TREE_DAY should be THREE_DAY, and MIN_DESCOUNT should be MIN_DISCOUNT. Fixing these will enhance the readability and maintainability of your code. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -3,8 +3,22 @@
*
* @return {number}
*/
const ONE_DAY = 40;
const TREE_DAY = 3;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable TREE_DAY seems to be a misspelling. It should likely be THREE_DAY to correctly represent the number three.

const ONE_DAY = 40;
const TREE_DAY = 3;
const SEVEN_DAY = 7;
const MIN_DESCOUNT = 20;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable MIN_DESCOUNT contains a spelling error. It should be MIN_DISCOUNT to correctly represent the concept of a discount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants