transportation-on-vacation-solution #5086
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this task! 😊 While your code is well-structured and meets many of the task requirements, there's a critical issue with the discount logic. Currently, the function only applies one discount, whereas it should apply both if the rental period qualifies. Please revise the logic to ensure both discounts are applied when applicable. Once this is addressed, your solution will be ready for approval. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/calculateRentalCost.js
Outdated
| if (days >= LONG_TERM) { | ||
| return basePrice - LONG_TERM_DISCOUNT; | ||
| } | ||
|
|
||
| if (days >= SHORT_TERM) { | ||
| return basePrice - SHORT_TERM_DISCOUNT; |
There was a problem hiding this comment.
The logic here only allows for one discount to be applied, either the long-term or the short-term discount, not both. According to the task description, if the rental period qualifies for both discounts, both should be applied. Consider revising the logic to ensure both discounts are applied when applicable.
There was a problem hiding this comment.
Failed tasks have been resolved
|
Failed tasks have been resolved |
No description provided.