Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #5107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ratseburzhynskyi
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the calculateRentalCost function! 🎉 Your code meets the task requirements and constraints effectively. The logic for applying discounts based on rental duration is mostly correct. However, ensure that the discount logic aligns with the task requirements—whether it's a flat discount or a per-day discount. Keep up the good work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +17 to +18
if (days >= shortTerm && days < longTerm) {
return days * basePrice - shortTermDiscount;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition days >= shortTerm && days < longTerm applies a short-term discount for rentals of 3 to 6 days. However, the discount is applied only once, regardless of the number of days. If the task requires a per-day discount, this logic should be adjusted. Otherwise, if a flat discount is intended, this is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants