Solution #5128
Solution #5128
Conversation
There was a problem hiding this comment.
Your solution is almost there! 😊 However, there's a critical issue that needs to be addressed before we can approve it. The use of hardcoded literals in your code goes against the task requirements. It's important to define constants for values like 7, 3, 50, and 20 to improve readability and maintainability. Once you make these changes, your code will be in great shape! Keep up the good work, and don't hesitate to reach out if you need any help. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
There was a problem hiding this comment.
Review Summary
Great job on improving the code structure by using constants for the discount values! 🎉 This change significantly enhances the readability and maintainability of your code. However, there's a critical issue with the discount logic that needs attention. Typically, the largest applicable discount should be applied, but your current logic applies only one discount based on the order of conditions. Please revise this logic to ensure the correct discount is applied.
Despite this issue, I'm approving your pull request to help you move forward with your learning journey. Make sure to review the comments and improve your code accordingly. Remember, addressing such issues will help you avoid similar problems in the future. Keep up the good work and continue learning from your experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| if (days >= secondDiscountDays) { | ||
| return total - secondDiscount; | ||
| } | ||
|
|
||
| if (days >= firstDiscountDays) { | ||
| return total - firstDiscount; |
There was a problem hiding this comment.
The current logic applies the second discount if the number of days is greater than or equal to secondDiscountDays, and the first discount if the number of days is greater than or equal to firstDiscountDays. This logic might not be correct if both discounts should be applied cumulatively or if only the largest applicable discount should be applied. Consider revising the logic to ensure the correct discount is applied according to the task requirements.
No description provided.