Solution* #5137
Solution* #5137
Conversation
There was a problem hiding this comment.
Great job on implementing the calculateRentalCost function! 🎉 Your code meets the task requirements and constraints, and you've used descriptive names and constants effectively. However, there is a logical error in the discount application. When the rental period is longer than 7 days, the current implementation does not apply both discounts correctly. To improve your code, consider adjusting the logic to ensure both discounts are applied when applicable.
Additionally, while your test cases are well-structured, there's a logical inconsistency in the expected results for the 7-day rental scenario. Make sure to review and correct these to ensure accurate testing.
Overall, your approach is solid, and with a few adjustments, it will be even better. Keep up the good work, and use this feedback to refine your solution. Remember, addressing these issues will help you avoid similar problems in the future and enhance your learning experience. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| if (days >= LONG_RENT) { | ||
| return basePrice - LONG_RENT_DISCOUNT; | ||
| } | ||
|
|
||
| if (days >= SHORT_RENT) { | ||
| return basePrice - SHORT_RENT_DISCOUNT; |
There was a problem hiding this comment.
There is a logical error in the discount application. If days is greater than or equal to LONG_RENT, the function returns immediately with the LONG_RENT_DISCOUNT, and the SHORT_RENT_DISCOUNT is never considered. To fix this, you should adjust the logic to apply both discounts correctly when applicable.
No description provided.