Solution #2288
Solution #2288
Conversation
src/makeRobot.js
Outdated
| @@ -39,6 +39,67 @@ | |||
| */ | |||
| function makeRobot(name, wheels, version) { | |||
| // write code here | |||
| const obj = { | |||
There was a problem hiding this comment.
The obj is not a descriptive variable name. It is recommended to use meaningful variable names. For example, you could use robot instead.
src/makeRobot.js
Outdated
|
|
||
| }; | ||
|
|
||
| obj.name = name; |
There was a problem hiding this comment.
If we do not change these fields ( name, version, and wheels) while working with the makeRobot function, it is better to define them at the beginning, during the creation of the object.
src/makeRobot.js
Outdated
| + ', chip version: ' | ||
| + this.version | ||
| + ', wheels: ' | ||
| + this.wheels; |
There was a problem hiding this comment.
You can return the string here just like you do in the getter location().
| this.coords.y -= value; | ||
| } | ||
|
|
||
| return this; |
There was a problem hiding this comment.
It is not necessary to return this every time, if we do some operation on the data and we do not need this as a result of execution.
There was a problem hiding this comment.
but without "return this" we can`t use them step by step like this :robot.goBack(1).goForward(17).goForward(-1).goLeft(3).goLeft(7).goRight();
| + ', wheels: ' | ||
| + this.wheels; | ||
| }, | ||
| get location() { |
There was a problem hiding this comment.
Do not forget about good formatting of the code (in this case, there is no empty line before each new method).
src/makeRobot.js
Outdated
| this.coords.x = 1400; | ||
| this.coords.y = 500; |
src/makeRobot.js
Outdated
| return `${name}: x=${this.coords.x}, y=${this.coords.y}`; | ||
| }, | ||
|
|
||
| goBack(value = 1) { |
No description provided.