add task solution #2351
Closed
add task solution #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiserett
suggested changes
Aug 6, 2023
src/makeRobot.js
Outdated
Comment on lines
54
to
60
| }, | ||
| get info() { | ||
| return `name: ${name}, chip version: ${version}, wheels: ${wheels}`; | ||
| }, | ||
| get location() { | ||
| return `${this.name}: x=${this.coords.x}, y=${this.coords.y}`; | ||
| }, |
src/makeRobot.js
Outdated
| y: 0, | ||
| }, | ||
| get info() { | ||
| return `name: ${name}, chip version: ${version}, wheels: ${wheels}`; |
There was a problem hiding this comment.
let's use 'this' here
If you will create a function to change these variables later - it will not work as expected without 'this'
src/makeRobot.js
Outdated
Comment on lines
63
to
69
| if (step < 1) { | ||
| return this; | ||
| } | ||
|
|
||
| this.coords.x -= step; | ||
|
|
||
| return this; |
There was a problem hiding this comment.
think on how you can refactor it to get rid of double 'return this' statement
roman-mirzoian
approved these changes
Aug 7, 2023
| x: 0, | ||
| y: 0, | ||
| }, | ||
| get info() { |
There was a problem hiding this comment.
Suggested change
| get info() { | |
| get info() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.