Solution #2370
Solution #2370
Conversation
src/makeRobot.js
Outdated
| goForward(value) { | ||
| if (!value) { | ||
| this.coords.y += 1; | ||
|
|
||
| return this; | ||
| } | ||
|
|
||
| if (value < 0) { | ||
| return this; | ||
| } | ||
| this.coords.y += value; | ||
|
|
||
| return this; | ||
| }, |
There was a problem hiding this comment.
you could simplified this and do something like
goForward(step = 1)
// some code
return this;
},
src/makeRobot.js
Outdated
| coords: { | ||
| x: 0, | ||
| y: 0, | ||
| }, |
There was a problem hiding this comment.
object properties should be defined before methods, please move those to other properties 🔼
src/makeRobot.js
Outdated
| goForward(value) { | ||
| if (!value) { | ||
| this.coords.y += 1; | ||
|
|
||
| return this; | ||
| } | ||
|
|
||
| if (value < 0) { | ||
| return this; | ||
| } | ||
| this.coords.y += value; | ||
|
|
||
| return this; | ||
| }, |
There was a problem hiding this comment.
| goForward(value) { | |
| if (!value) { | |
| this.coords.y += 1; | |
| return this; | |
| } | |
| if (value < 0) { | |
| return this; | |
| } | |
| this.coords.y += value; | |
| return this; | |
| }, | |
| goForward(value) { | |
| if (value > 0) { | |
| this.coords.y += 1; | |
| } | |
| return this | |
| }, |
There was a problem hiding this comment.
But in case the value is 9, the robot should take 9 steps, not 1. So I think your solution is wrong 😉
I think you thought about this solution:
goForward(value = 1) {
if (value > 0) {
this.coords.y += value;
}
return this;
},
src/makeRobot.js
Outdated
| return this; | ||
| }, | ||
|
|
||
| goBack(value) { |
There was a problem hiding this comment.
please rewrite this function according to my suggestion in goForward method
src/makeRobot.js
Outdated
| return this; | ||
| }, | ||
|
|
||
| goLeft(value) { |
There was a problem hiding this comment.
please rewrite this function according to my suggestion in goForward method
src/makeRobot.js
Outdated
| return this; | ||
| }, | ||
|
|
||
| goRight(value) { |
There was a problem hiding this comment.
please rewrite this function according to my suggestion in goForward method
No description provided.