solution #2382
Open
solution #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choeqq
suggested changes
Jul 27, 2023
src/makeRobot.js
Outdated
| @@ -39,6 +39,73 @@ | |||
| */ | |||
| function makeRobot(name, wheels, version) { | |||
| // write code here | |||
| const Robot = { | |||
There was a problem hiding this comment.
capital first letter names are reserved for JS classes - please use plain object - robot
src/makeRobot.js
Outdated
Comment on lines
103
to
105
| name, | ||
| wheels, | ||
| version, |
There was a problem hiding this comment.
properties are always first in each object, then goes functions (methods), please move those on top
src/makeRobot.js
Outdated
Comment on lines
51
to
54
| coords: { | ||
| x: 0, | ||
| y: 0, | ||
| }, |
There was a problem hiding this comment.
properties are always first in each object, then goes functions (methods), please move those on top
src/makeRobot.js
Outdated
|
|
||
| return this; | ||
| }, | ||
| evacuate: function evacuate() { |
src/makeRobot.js
Outdated
Comment on lines
89
to
91
| if (step < 0) { | ||
| this.coords.x = this.coords.x; | ||
| } |
src/makeRobot.js
Outdated
| }, | ||
| goLeft(step = 1) { | ||
| if (step < 0) { | ||
| this.coords.x = this.coords.x; |
src/makeRobot.js
Outdated
| }, | ||
| goBack(step = 1) { | ||
| if (step < 0) { | ||
| this.coords.y = this.coords.y; |
src/makeRobot.js
Outdated
| }, | ||
| goForward(step = 1) { | ||
| if (step < 0) { | ||
| this.coords.y = this.coords.y; |
JoyCoffeeAddict
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.