Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #2403

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

sadcatpuchino
Copy link

No description provided.

src/makeRobot.js Outdated
Comment on lines 44 to 46
name: name,
wheels: wheels,
version: version,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checklist point 1

src/makeRobot.js Outdated
@@ -38,7 +38,65 @@
* @return {Robot}
*/
function makeRobot(name, wheels, version) {
// write code here
let isEvacuated = false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after robot is evacutaed once, the flag will be set true forever, which mean that we won't be able to see info after moving robot around when he was evacuated - please omit that flag

src/makeRobot.js Outdated
Comment on lines 51 to 52
if (isEvacuated) {
return `Robot has been evacuated to the service center.`;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment above ⏫

src/makeRobot.js Outdated
this.coords = {
x: 1400, y: 500,
};
isEvacuated = true;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please omit that

src/makeRobot.js Outdated
};
isEvacuated = true;

return this;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evaluate method doesn't need to return this

Copy link

@choeqq choeqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants