-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #2409
base: master
Are you sure you want to change the base?
Develop #2409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Almost done!
src/makeRobot.js
Outdated
|
||
get goRight() { | ||
return function(value = 1) { | ||
if (value < 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (value < 0) { | |
if (value > 0) { |
src/makeRobot.js
Outdated
get goRight() { | ||
return function(value = 1) { | ||
if (value < 0) { | ||
return this; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return this; | |
this.coords.x += value; |
src/makeRobot.js
Outdated
if (value < 0) { | ||
return this; | ||
} | ||
this.coords.x += value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.coords.x += value; |
src/makeRobot.js
Outdated
|
||
get goBack() { | ||
return function(value = 1) { | ||
if (value < 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my previous comment
src/makeRobot.js
Outdated
get goForward() { | ||
return function(value = 1) { | ||
if (value < 0) { | ||
return this; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same issue here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
No description provided.