Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2409

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #2409

wants to merge 3 commits into from

Conversation

Val-Bryks
Copy link

No description provided.

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Almost done!

src/makeRobot.js Outdated

get goRight() {
return function(value = 1) {
if (value < 0) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (value < 0) {
if (value > 0) {

src/makeRobot.js Outdated
get goRight() {
return function(value = 1) {
if (value < 0) {
return this;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return this;
this.coords.x += value;

src/makeRobot.js Outdated
if (value < 0) {
return this;
}
this.coords.x += value;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.coords.x += value;

src/makeRobot.js Show resolved Hide resolved
src/makeRobot.js Outdated

get goBack() {
return function(value = 1) {
if (value < 0) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment

src/makeRobot.js Outdated
get goForward() {
return function(value = 1) {
if (value < 0) {
return this;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same issue here

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants