-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #2436
base: master
Are you sure you want to change the base?
Solution #2436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👍
But let's improve it
src/makeRobot.js
Outdated
name, | ||
|
||
wheels, | ||
|
||
version, | ||
|
||
coords: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name, | |
wheels, | |
version, | |
coords: { | |
name, | |
wheels, | |
version, | |
coords: { |
src/makeRobot.js
Outdated
return `${this.name}: x=${this.coords.x}, y=${this.coords.y}`; | ||
}, | ||
|
||
goForward(distance = 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goForward(distance = 1) { | |
goForward(step = 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's better name, please change it everywhere
src/makeRobot.js
Outdated
this.coords.x = 1400; | ||
this.coords.y = 500; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using "magic numbers"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 👍
No description provided.