Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #2436

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #2436

wants to merge 3 commits into from

Conversation

AndrMar1939
Copy link

No description provided.

Copy link

@Moroz-Dmytro Moroz-Dmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍
But let's improve it

src/makeRobot.js Outdated
Comment on lines 42 to 48
name,

wheels,

version,

coords: {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name,
wheels,
version,
coords: {
name,
wheels,
version,
coords: {

src/makeRobot.js Outdated
return `${this.name}: x=${this.coords.x}, y=${this.coords.y}`;
},

goForward(distance = 1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
goForward(distance = 1) {
goForward(step = 1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's better name, please change it everywhere

src/makeRobot.js Outdated
Comment on lines 98 to 99
this.coords.x = 1400;
this.coords.y = 500;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using "magic numbers"

Copy link

@Moroz-Dmytro Moroz-Dmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants