Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #2439

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #2439

wants to merge 2 commits into from

Conversation

Vannnkof
Copy link

@Vannnkof Vannnkof commented Aug 2, 2023

No description provided.

Copy link

@KatOlista KatOlista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!
Maybe will be better to use an outside variable for evacuation coordinates

Copy link

@Moroz-Dmytro Moroz-Dmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍
But let's improve your code

src/makeRobot.js Outdated
return `${this.name}: x=${this.coords.x}, y=${this.coords.y}`;
},

goForward(value = 1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

step is better name than just value

src/makeRobot.js Outdated
Comment on lines 92 to 93
this.coords.x = 1400;
this.coords.y = 500;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using "magic numbers"

Copy link

@Moroz-Dmytro Moroz-Dmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants