-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solved task #2441
base: master
Are you sure you want to change the base?
solved task #2441
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,73 @@ | |
* @return {Robot} | ||
*/ | ||
function makeRobot(name, wheels, version) { | ||
// write code here | ||
const robot = { | ||
name, | ||
wheels, | ||
version, | ||
|
||
coords: { | ||
x: 0, | ||
y: 0, | ||
}, | ||
|
||
evacuate() { | ||
this.coords.x = 1400; | ||
this.coords.y = 500; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. avoid using "magic numbers" |
||
}, | ||
|
||
get info() { | ||
return `name: ${this.name}, ` | ||
+ `chip version: ${this.version}, ` | ||
+ `wheels: ${this.wheels}`; | ||
}, | ||
|
||
get location() { | ||
return `${this.name}: x=${this.coords.x}, y=${this.coords.y}`; | ||
}, | ||
|
||
goForward(distance) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
const coordinate = distance === undefined | ||
? 1 | ||
: Math.max(0, distance); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Try to simplify this(you can set default parameters) |
||
|
||
this.coords.y += coordinate; | ||
|
||
return this; | ||
}, | ||
|
||
goBack(distance) { | ||
const coordinate = distance === undefined | ||
? 1 | ||
: Math.max(0, distance); | ||
|
||
this.coords.y -= coordinate; | ||
|
||
return this; | ||
}, | ||
|
||
goRight(distance) { | ||
const coordinate = distance === undefined | ||
? 1 | ||
: Math.max(0, distance); | ||
|
||
this.coords.x += coordinate; | ||
|
||
return this; | ||
}, | ||
|
||
goLeft(distance) { | ||
const coordinate = distance === undefined | ||
? 1 | ||
: Math.max(0, distance); | ||
|
||
this.coords.x -= coordinate; | ||
|
||
return this; | ||
}, | ||
}; | ||
|
||
return robot; | ||
} | ||
|
||
module.exports = makeRobot; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this gap is redundant