-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finish solution #2481
base: master
Are you sure you want to change the base?
finish solution #2481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Let's get rid of magic numbers
src/makeRobot.js
Outdated
this.coords.y = 500; | ||
this.coords.x = 1400; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid magic numbers.
src/makeRobot.js
Outdated
if (step < 0) { | ||
return this; | ||
} | ||
|
||
this.coords.y += step; | ||
|
||
return this; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how can we avoid writing 'return this' statement twice?
left one disable linter for the test