Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish solution #2481

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

serkrops
Copy link

@serkrops serkrops commented Aug 6, 2023

left one disable linter for the test

Copy link

@BudnikOleksii BudnikOleksii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Let's get rid of magic numbers

src/makeRobot.js Outdated
Comment on lines 101 to 102
this.coords.y = 500;
this.coords.x = 1400;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid magic numbers.

src/makeRobot.js Outdated
Comment on lines 61 to 67
if (step < 0) {
return this;
}

this.coords.y += step;

return this;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we avoid writing 'return this' statement twice?

@serkrops serkrops requested a review from tiserett August 8, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants