soltion #2492
Open
soltion #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radoslaw-Czerniawski
suggested changes
Aug 14, 2023
src/makeRobot.js
Outdated
| }, | ||
|
|
||
| get info() { | ||
| return 'name: ' + this.name + ', chip version: ' |
There was a problem hiding this comment.
Generally prefer string interpolation over concatenation
return `name: ${this.name}, chip version: ${this.version}, wheels: ${this.wheels}`;
src/makeRobot.js
Outdated
| @@ -38,7 +38,65 @@ | |||
| * @return {Robot} | |||
| */ | |||
| function makeRobot(name, wheels, version) { | |||
| // write code here | |||
| const robot = { | |||
There was a problem hiding this comment.
You don't need to declare a variable, just return this object here
return {
name,
version,
...
src/makeRobot.js
Outdated
| }, | ||
|
|
||
| goForward(move = 1) { | ||
| if (move > 0) { |
There was a problem hiding this comment.
Currently there is no way of knowing whether user passes a number to this method
- for example string
00023is greater than number 0 - I could pass it to this method and overwrite some coordinate into a string
There was a problem hiding this comment.
It would be best to declare some method on this robot that object will help with evaluating whether your move is a number and whether it's greater than 0, it could be used in the if condition like so
if (this.isPositiveNumber(move)) {
mykhalenych
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.