-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My hometask dependency injection #1005
Open
skucherenko7
wants to merge
2
commits into
mate-academy:main
Choose a base branch
from
skucherenko7:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,11 @@ | ||
package mate.academy.lib; | ||
|
||
public @interface Component { | ||
import java.lang.annotation.ElementType; | ||
import java.lang.annotation.Retention; | ||
import java.lang.annotation.RetentionPolicy; | ||
import java.lang.annotation.Target; | ||
|
||
@Target(ElementType.TYPE) | ||
@Retention(RetentionPolicy.RUNTIME) | ||
public @interface Component { | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,11 @@ | ||
package mate.academy.lib; | ||
|
||
public @interface Inject { | ||
import java.lang.annotation.ElementType; | ||
import java.lang.annotation.Retention; | ||
import java.lang.annotation.RetentionPolicy; | ||
import java.lang.annotation.Target; | ||
|
||
@Target(ElementType.FIELD) | ||
@Retention(RetentionPolicy.RUNTIME) | ||
public @interface Inject { | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,89 @@ | ||
package mate.academy.lib; | ||
|
||
import java.lang.reflect.Constructor; | ||
import java.lang.reflect.Field; | ||
import java.util.HashMap; | ||
import java.util.Map; | ||
import mate.academy.service.FileReaderService; | ||
import mate.academy.service.ProductParser; | ||
import mate.academy.service.ProductService; | ||
import mate.academy.service.impl.FileReaderServiceImpl; | ||
import mate.academy.service.impl.ProductParserImpl; | ||
import mate.academy.service.impl.ProductServiceImpl; | ||
|
||
public class Injector { | ||
|
||
private static final Map<Class<?>, Class<?>> interfaceImplementations = Map.of( | ||
FileReaderService.class, FileReaderServiceImpl.class, | ||
ProductParser.class, ProductParserImpl.class, | ||
ProductService.class, ProductServiceImpl.class | ||
); | ||
|
||
private static final Injector injector = new Injector(); | ||
private final Map<Class<?>, Object> instances = new HashMap<>(); | ||
|
||
public static Injector getInjector() { | ||
return injector; | ||
} | ||
|
||
public Object getInstance(Class<?> interfaceClazz) { | ||
return null; | ||
Object clazzImplementationInstance = null; | ||
Class<?> clazzImplementation = findImplementation(interfaceClazz); | ||
|
||
if (!clazzImplementation.isAnnotationPresent(Component.class)) { | ||
throw new RuntimeException("Injection failed: missing @Component " | ||
+ "annotation on the class " + clazzImplementation.getName()); | ||
} | ||
clazzImplementationInstance = createNewInstance(clazzImplementation); | ||
|
||
Field[] fields = clazzImplementation.getDeclaredFields(); | ||
|
||
for (Field field : fields) { | ||
if (field.isAnnotationPresent(Inject.class)) { | ||
Object fieldTypeObject = getInstance(field.getType()); | ||
try { | ||
field.setAccessible(true); | ||
field.set(clazzImplementationInstance, fieldTypeObject); | ||
} catch (IllegalAccessException e) { | ||
|
||
throw new RuntimeException("Injection failed: can't initialize field " | ||
+ field.getName() + " in class " + clazzImplementation.getName(), e); | ||
} | ||
} | ||
} | ||
return clazzImplementationInstance; | ||
} | ||
|
||
private Object createNewInstance(Class<?> clazzImplementation) { | ||
|
||
if (!clazzImplementation.isAnnotationPresent(Component.class)) { | ||
throw new RuntimeException("Can't create instance of class: " | ||
+ clazzImplementation.getName() | ||
+ " because it is missing @Component annotation."); | ||
} | ||
if (instances.containsKey(clazzImplementation)) { | ||
return instances.get(clazzImplementation); | ||
} | ||
try { | ||
Constructor<?> constructor = clazzImplementation.getConstructor(); | ||
Object newInstance = constructor.newInstance(); | ||
instances.put(clazzImplementation, newInstance); | ||
return newInstance; | ||
} catch (ReflectiveOperationException e) { | ||
throw new RuntimeException("Creation failed: can't create instance of class " | ||
+ clazzImplementation.getName(), e); | ||
} | ||
} | ||
|
||
private Class<?> findImplementation(Class<?> clazz) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't forget about annotations checks in your Injector class. You should check if the class has the @component annotation before attempting to create an instance. |
||
if (clazz.isInterface()) { | ||
Class<?> implementation = interfaceImplementations.get(clazz); | ||
if (implementation == null) { | ||
throw new RuntimeException("Implementation not found for interface: " | ||
+ clazz.getName()); | ||
} | ||
return implementation; | ||
} | ||
throw new RuntimeException("Expected an interface but got class: " + clazz.getName()); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
src/main/java/mate.academy/service/impl/ProductParserImpl.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to replace many exceptions that have a common parent with a general parental exception. In this case, you can catch
ReflectiveOperationException
instead of listing all reflective exceptions separately.