-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My hometask dependency injection #1005
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,11 @@ | ||
package mate.academy.lib; | ||
|
||
public @interface Component { | ||
import java.lang.annotation.ElementType; | ||
import java.lang.annotation.Retention; | ||
import java.lang.annotation.RetentionPolicy; | ||
import java.lang.annotation.Target; | ||
|
||
@Target(ElementType.TYPE) | ||
@Retention(RetentionPolicy.RUNTIME) | ||
public @interface Component { | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,11 @@ | ||
package mate.academy.lib; | ||
|
||
public @interface Inject { | ||
import java.lang.annotation.ElementType; | ||
import java.lang.annotation.Retention; | ||
import java.lang.annotation.RetentionPolicy; | ||
import java.lang.annotation.Target; | ||
|
||
@Target(ElementType.FIELD) | ||
@Retention(RetentionPolicy.RUNTIME) | ||
public @interface Inject { | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,82 @@ | ||
package mate.academy.lib; | ||
|
||
import java.lang.reflect.Constructor; | ||
import java.lang.reflect.Field; | ||
import java.util.HashMap; | ||
import java.util.Map; | ||
import mate.academy.service.FileReaderService; | ||
import mate.academy.service.ProductParser; | ||
import mate.academy.service.ProductService; | ||
import mate.academy.service.impl.FileReaderServiceImpl; | ||
import mate.academy.service.impl.ProductParserImpl; | ||
import mate.academy.service.impl.ProductServiceImpl; | ||
|
||
public class Injector { | ||
|
||
static { | ||
interfaceImplementations = | ||
Map.of(FileReaderService.class, FileReaderServiceImpl.class, | ||
ProductParser.class, ProductParserImpl.class, | ||
ProductService.class, ProductServiceImpl.class | ||
); | ||
} | ||
|
||
private static final Injector injector = new Injector(); | ||
private static final Map<Class<?>, Class<?>> interfaceImplementations; | ||
private final Map<Class<?>, Object> instances = new HashMap<>(); | ||
|
||
public static Injector getInjector() { | ||
return injector; | ||
} | ||
|
||
public Object getInstance(Class<?> interfaceClazz) { | ||
return null; | ||
|
||
Object clazzImplementationInstance = null; | ||
Class<?> clazzImplementation = findImplementation(interfaceClazz); | ||
if (!clazzImplementation.isAnnotationPresent(Component.class)) { | ||
throw new RuntimeException("Class implementation: " | ||
+ clazzImplementation.getName() | ||
+ "doesn't have 'Component' annotation "); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When throwing an exception, add an informative message to it. Also, include the caught exception in the |
||
} | ||
Field[] fields = clazzImplementation.getFields(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should use clazz.getDeclaredFields() instead of clazz.getFields() to also include private fields in your search, as getFields() only returns public fields including inherited ones. |
||
|
||
for (Field field : fields) { | ||
if (field.isAnnotationPresent(Inject.class)) { | ||
Object fieldTypeObject = getInstance(field.getType()); | ||
clazzImplementationInstance = createNewInstance(clazzImplementation); | ||
try { | ||
field.setAccessible(true); | ||
field.set(clazzImplementationInstance, fieldTypeObject); | ||
} catch (IllegalAccessException e) { | ||
throw new RuntimeException("Can't initialize field: " + field.getName()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When rethrowing the exception, you should include the original exception as a cause to maintain the stack trace. For example: |
||
} | ||
} | ||
} | ||
if (clazzImplementationInstance == null) { | ||
clazzImplementationInstance = createNewInstance(clazzImplementation); | ||
} | ||
return clazzImplementationInstance; | ||
} | ||
|
||
private Object createNewInstance(Class<?> clazzImplementation) { | ||
if (instances.containsKey(clazzImplementation)) { | ||
return instances.get(clazzImplementation); | ||
} | ||
try { | ||
Constructor<?> constructor = clazzImplementation.getConstructor(); | ||
Object newInstance = constructor.newInstance(); | ||
instances.put(clazzImplementation, newInstance); | ||
return newInstance; | ||
} catch (ReflectiveOperationException e) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is better to replace many exceptions that have a common parent with a general parental exception. In this case, you can catch |
||
throw new RuntimeException("Can't create instance of class: " | ||
+ clazzImplementation.getName()); | ||
} | ||
} | ||
|
||
private Class<?> findImplementation(Class<?> clazz) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't forget about annotations checks in your Injector class. You should check if the class has the @component annotation before attempting to create an instance. |
||
if (clazz.isInterface()) { | ||
return interfaceImplementations.get(clazz); | ||
} | ||
throw new RuntimeException("Unsupported type class: " + clazz.getName()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This exception message could be more informative by explaining that the class is not an interface. For example: |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make Interface Implementations map a class field. You can fill it in using
Map.of()
. However, it should be initialized in a static block or directly upon declaration, not in both places.