Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented dependency injection mechanism #1024

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/mate.academy/Main.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@
public class Main {

public static void main(String[] args) {
// Please test your Injector here. Feel free to push this class as a part of your solution
Injector injector = Injector.getInjector();
ProductService productService = null;
ProductService productService = (ProductService) injector.getInstance(ProductService.class);
List<Product> products = productService.getAllFromFile("products.txt");
products.forEach(System.out::println);
}
Expand Down
5 changes: 4 additions & 1 deletion src/main/java/mate.academy/lib/Component.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package mate.academy.lib;

public @interface Component {
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;

@Retention(RetentionPolicy.RUNTIME)
public @interface Component {
}
5 changes: 4 additions & 1 deletion src/main/java/mate.academy/lib/Inject.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package mate.academy.lib;

public @interface Inject {
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;

@Retention(RetentionPolicy.RUNTIME)
public @interface Inject {
}
51 changes: 50 additions & 1 deletion src/main/java/mate.academy/lib/Injector.java
Original file line number Diff line number Diff line change
@@ -1,13 +1,62 @@
package mate.academy.lib;

import java.lang.reflect.Constructor;
import java.lang.reflect.Field;
import java.util.HashMap;
import java.util.Map;
import mate.academy.service.FileReaderService;
import mate.academy.service.ProductParser;
import mate.academy.service.ProductService;

public class Injector {
private static final Injector injector = new Injector();
private final Map<Class<?>, Object> instances = new HashMap<>();

public static Injector getInjector() {
return injector;
}

public Object getInstance(Class<?> interfaceClazz) {
return null;
if (instances.containsKey(interfaceClazz)) {
return instances.get(interfaceClazz);
}
Class<?> clazz = findImplementation(interfaceClazz);
if (clazz == null || !clazz.isAnnotationPresent(Component.class)) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the Component annotation is correctly applied to all classes that should be managed by the injector. If a class is missing this annotation, it will cause a RuntimeException.

throw new RuntimeException("No implementation found for: " + interfaceClazz.getName());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider providing more detailed error messages or logging to help diagnose issues when no implementation is found.

}
Object instance = createInstance(clazz);
instances.put(interfaceClazz, instance);
return instance;
}

private Class<?> findImplementation(Class<?> interfaceClazz) {
if (interfaceClazz.isInterface()) {
if (interfaceClazz.equals(FileReaderService.class)) {
return mate.academy.service.impl.FileReaderServiceImpl.class;
} else if (interfaceClazz.equals(ProductParser.class)) {
return mate.academy.service.impl.ProductParserImpl.class;
} else if (interfaceClazz.equals(ProductService.class)) {
return mate.academy.service.impl.ProductServiceImpl.class;
}
}
return interfaceClazz;
}

private Object createInstance(Class<?> clazz) {
Constructor<?> constructor;
try {
constructor = clazz.getDeclaredConstructor();
Object instance = constructor.newInstance();
for (Field field : clazz.getDeclaredFields()) {
if (field.isAnnotationPresent(Inject.class)) {
field.setAccessible(true);
Object fieldInstance = getInstance(field.getType());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that circular dependencies are not present, as this could lead to a StackOverflowError during instance creation.

field.set(instance, fieldInstance);
}
}
return instance;
} catch (Exception e) {
throw new RuntimeException("Can't create instance of class: " + clazz.getName(), e);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
import java.io.IOException;
import java.nio.file.Files;
import java.util.List;
import mate.academy.lib.Component;
import mate.academy.service.FileReaderService;

@Component
public class FileReaderServiceImpl implements FileReaderService {
@Override
public List<String> readFile(String fileName) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package mate.academy.service.impl;

import java.math.BigDecimal;
import mate.academy.lib.Component;
import mate.academy.model.Product;
import mate.academy.service.ProductParser;

@Component
public class ProductParserImpl implements ProductParser {
public static final int ID_POSITION = 0;
public static final int NAME_POSITION = 1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,18 @@

import java.util.List;
import java.util.stream.Collectors;
import mate.academy.lib.Component;
import mate.academy.lib.Inject;
import mate.academy.model.Product;
import mate.academy.service.FileReaderService;
import mate.academy.service.ProductParser;
import mate.academy.service.ProductService;

@Component
public class ProductServiceImpl implements ProductService {
@Inject
private ProductParser productParser;
@Inject
private FileReaderService fileReaderService;

@Override
Expand Down
Loading