implemented injector #707
Open
implemented injector #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keda-vlad
suggested changes
Aug 7, 2023
|
|
||
| @Component |
There was a problem hiding this comment.
U don't need annotation here, only for implementations
"Convention is to use @component on the classes that are used for instance creation (usually these are interface implementations) "
Comment on lines
6
to
7
| @Component | ||
| public interface ProductParser { |
Comment on lines
7
to
8
| @Component | ||
| public interface ProductService { |
vovasalyha
approved these changes
Aug 8, 2023
| return null; | ||
| Object clazzImplementationInstance = null; | ||
| Class<?> clazz = findImplementation(interfaceClazz); | ||
| if (clazz.isAnnotationPresent(Component.class)) { |
There was a problem hiding this comment.
It's better to check in if statement if annotation is absent and throw exception if true (better even create a separate method to check it). It'll make your code cleaner.
keda-vlad
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.