create abstract class Machine and some machines and override 2 method… #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of abstract classes
Elena-Bruyako
suggested changes
Aug 7, 2023
| @@ -1,5 +1,14 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class MainApp { | |||
|
|
|||
| public static void main(String[] args) { | |||
| Excavator excavator = new Excavator(); | |||
There was a problem hiding this comment.
Your implementation won’t allow us to use polymorphism in the code. Your reference is bonded to specific implementation, but it is always better to depend on the abstraction.
Machine excavator = new Excavator();
liliia-ponomarenko
approved these changes
Aug 8, 2023
| package core.basesyntax; | ||
|
|
||
| public abstract class Machine { | ||
|
|
There was a problem hiding this comment.
Suggested change
| Machine bulldozer = new Bulldozer(); | ||
| Machine truck = new Truck(); | ||
| Machine[] machines = {excavator, truck, bulldozer}; | ||
| for (Machine machine:machines) { |
There was a problem hiding this comment.
Suggested change
| for (Machine machine:machines) { | |
| for (Machine machine : machines) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s of abstract classes