Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix problem with style code #1572

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

Alex-zzzz
Copy link

No description provided.

# Conflicts:
#	src/main/java/core/basesyntax/Bulldozer.java
#	src/main/java/core/basesyntax/Excavator.java
#	src/main/java/core/basesyntax/Machine.java
#	src/main/java/core/basesyntax/MainApp.java
#	src/main/java/core/basesyntax/Truck.java
Delete Override hashcode
Change fori to foreach
i put empty line between methods
chanhe loop.  I checked in development environment it works
add whitespace
@Ivan95kos Ivan95kos self-assigned this Aug 2, 2023
@Ivan95kos Ivan95kos self-requested a review August 2, 2023 16:34
@Ivan95kos Ivan95kos removed their assignment Aug 2, 2023
# Conflicts:
#	src/main/java/core/basesyntax/Bulldozer.java
#	src/main/java/core/basesyntax/Machine.java
#	src/main/java/core/basesyntax/MainApp.java
Copy link

@Ivan95kos Ivan95kos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, with minor comments

Comment on lines +14 to +16



Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line

Suggested change

package core.basesyntax;

public class Excavator extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the first empty line in all classes/interfaces/methods where it is present

Suggested change

public abstract void doWork();

public abstract void stopWork();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the last empty line in all classes/interfaces/methods where it is present

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants