first try #1595
Open
first try #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliia-ponomarenko
suggested changes
Aug 10, 2023
README.md
Outdated
Comment on lines
3
to
7
| - Create class core.basesyntax.Machine containing methods `public abstract void doWork()` and `public abstract void stopWork()`. | ||
| - Create classes `core.basesyntax.Truck`, `core.basesyntax.Bulldozer`, `core.basesyntax.Excavator` that will inherit from `core.basesyntax.Machine`. | ||
| - In those classes override `doWork()`, so it will print message that certain machine started its work. | ||
| - Override `stopWork()` as well. It should print messages that certain machine stopped its work. | ||
| - In `MainApp` class create `Machine` array with `Truck`, `Bulldozer` and `Excavator` and call methods `doWork()` and `stopWork()` in a loop. | ||
| - In `MainApp` class create `core.basesyntax.Machine` array with `core.basesyntax.Truck`, `core.basesyntax.Bulldozer` and `core.basesyntax.Excavator` and call methods `doWork()` and `stopWork()` in a loop. |
There was a problem hiding this comment.
You don’t need to change README file. Let’s revert the changes.
checklist.md
Outdated
Comment on lines
26
to
27
| message should indicate what type of `core.basesyntax.Machine` is working right now `core.basesyntax.Truck`, `core.basesyntax.Bulldozer` or `core.basesyntax.Excavator`. | ||
|
|
|
|
||
| public class Bulldozer extends Machine { | ||
| public void doWork() { | ||
| System.out.println("core.basesyntax.Bulldozer started its work"); |
There was a problem hiding this comment.
Don’t use package names in messages. Let’s remove it everywhere
| public void stopWork() { | ||
| System.out.println("core.basesyntax.Bulldozer stoped its work"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Redundant empty line
| package core.basesyntax; | ||
|
|
||
| public class Excavator extends Machine { | ||
|
|
There was a problem hiding this comment.
Redundant empty line
| public class Truck extends Machine { | ||
|
|
||
| public void doWork() { | ||
|
|
There was a problem hiding this comment.
Redundant empty line
| public void stopWork() { | ||
| System.out.println("core.basesyntax.Truck stoped its work"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Redundant empty line
Andriy-dz
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.