Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- створив необхідні класи за умовами; #1600

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

- створив необхідні класи за умовами; #1600

wants to merge 5 commits into from

Conversation

andriimikhaylovskiy
Copy link

  • перевизначив методи doWork() та stopWork();
  • у MainApp створив масив Machine з заданими даними і викликав для нього методи doWork() та stopWork().

@andriimikhaylovskiy
- створив необхідні класи за умовами;
9781836 
- перевизначив методи doWork() та stopWork();
- у MainApp створив масив Machine з заданими даними і викликав для нього методи doWork() та stopWork().
olekskov
olekskov suggested changes Aug 10, 2023
View reviewed changes
Copy link

@olekskov olekskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix build to proceed with review.
Use 'mvn clean package' command locally to see the result of build and errors description

okuzan
okuzan suggested changes Aug 11, 2023
View reviewed changes
src/main/java/core/basesyntax/Machine.java Outdated
Comment on lines 9 to 12




Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra lines

src/main/java/core/basesyntax/Truck.java Outdated
package core.basesyntax;

public class Truck extends Machine {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line after class definition, fix everywhere

olekskov
olekskov approved these changes Aug 12, 2023
View reviewed changes
Copy link

@olekskov olekskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olekskov olekskov olekskov approved these changes

@okuzan okuzan Awaiting requested review from okuzan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andriimikhaylovskiy @okuzan @olekskov