First solution #2161
First solution #2161
Conversation
There was a problem hiding this comment.
Great job on following the task requirements! Just a few minor style issues to keep in mind for next time. Remember to add spaces for readability and make your print statements informative to enhance clarity. Keep up the good work! 😊👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -0,0 +1,13 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Bulldozer extends Machine{ | |||
There was a problem hiding this comment.
There should be a space between the class name and the opening brace to conform with Java coding standards.
| public class Bulldozer extends Machine{ | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Bulldozer started working"); |
There was a problem hiding this comment.
The message in System.out.println should indicate the type of machine, which you have correctly done, but consider making it more informative. For example: 'Bulldozer is starting its work'.
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Bulldozer stopped working"); |
There was a problem hiding this comment.
Similarly, the stop message could be more informative, e.g., 'Bulldozer has finished its work and is shutting down'.
| @@ -0,0 +1,13 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Excavator extends Machine{ | |||
There was a problem hiding this comment.
There should be a space between the class name Machine and the curly brace { to adhere to Java code style conventions.
| public class Excavator extends Machine{ | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Excavator started working"); |
There was a problem hiding this comment.
The message in System.out.println should be more informative and indicate that it is an Excavator that has started working, as per the checklist's requirement to use informative messages.
| @@ -1,5 +1,12 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class MainApp { | |||
| public static void main(String[] args){ | |||
There was a problem hiding this comment.
Please ensure that there is a space between the closing parenthesis of the method signature and the opening curly brace { to adhere to Java code conventions.
|
|
||
| for (Machine machine : machines){ |
There was a problem hiding this comment.
There should be a space after for and before the opening parenthesis ( to maintain consistent code style.
| @@ -0,0 +1,13 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Truck extends Machine{ | |||
There was a problem hiding this comment.
There is a missing space between the class name 'Machine' and the opening brace '{'. It should be extends Machine { to follow Java code conventions.
| public class Truck extends Machine{ | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Truck started working"); |
There was a problem hiding this comment.
The message in the System.out.println should be more informative. Mention that it is a Truck that has started working, to provide clarity in the output.
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Truck stopped working"); |
There was a problem hiding this comment.
Similarly, the stop message should be more informative. Indicate that it is a Truck that has stopped working.
No description provided.