solved task #2170
solved task #2170
Conversation
There was a problem hiding this comment.
Great work on implementing the Bulldozer class and the MainApp class! 👍 It looks like you've followed the checklist guidelines and provided the necessary functionality. Remember that informative messages and clean code formatting can always enhance readability and maintainability, but these are minor issues and don't warrant a change request. Keep up the good work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -0,0 +1,13 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Excavator extends Machine{ | |||
There was a problem hiding this comment.
There should not be a redundant empty line after the class declaration. Please remove the empty line to improve code readability, adhering to the checklist item regarding redundant empty lines.
| public void doWork() { | ||
| System.out.println("Excavator started working."); |
There was a problem hiding this comment.
The message in the doWork method should be more informative. It should indicate that the 'Excavator' is working, not just started working. For example, 'Excavator is excavating.'
| public void stopWork() { | ||
| System.out.println("Excavator stopped working."); |
There was a problem hiding this comment.
Similarly, the message in the stopWork method should be more informative about the 'Excavator' stopping its work. For instance, 'Excavator has finished excavating.'
| public class Truck extends Machine { | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Truck started working."); |
There was a problem hiding this comment.
The message 'Truck started working.' is not very informative. It would be better to specify what kind of work the Truck is doing to make the message more informative, as per the checklist.
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Truck stopped working."); |
There was a problem hiding this comment.
Similarly to the doWork method, the message in stopWork should be more informative. Indicate what kind of work has been stopped by the Truck.
No description provided.