implemented rick & morty task #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olekskov
suggested changes
Oct 21, 2023
| @Component | ||
| public class RickAndMortyClientImpl implements RickAndMortyClient { | ||
| private static final String BASE_URL = "https://rickandmortyapi.com/api/character/%s"; | ||
| private int characterSize; |
There was a problem hiding this comment.
I don't like idea to store data in bean class variable
Spring Data JPA provides a built-in count() method for each repository interface. You can use this method to count the number of rows in a table with characters
Comment on lines
50
to
53
| @Override | ||
| public int getCharactersSize() { | ||
| return characterSize; | ||
| } |
Comment on lines
23
to
27
| int charactersSize = rickAndMortyClient.getCharactersSize(); | ||
| long characterId | ||
| = new Random().nextLong(charactersSize - FIRST_CHARACTER_INDEX + ONE) | ||
| + FIRST_CHARACTER_INDEX; | ||
| return characterRepository.findCharacterByExternalId(characterId) |
There was a problem hiding this comment.
I'd not rely on consistency of external ids
what if they have UUID or predefined step or some missing ids due to deletion of entries?
Please use reliable way to get random entry from your DB
Ivan95kos
approved these changes
Oct 22, 2023
| @RequiredArgsConstructor | ||
| @Component | ||
| public class RickAndMortyClientImpl implements RickAndMortyClient { | ||
| private static final String BASE_URL = "https://rickandmortyapi.com/api/character/%s"; |
There was a problem hiding this comment.
this can be stored in your app properties, and then be injected here via @value
| characterRepository.saveAll(entityList); | ||
| saveNextCharacters(page, responseDto, httpClient); | ||
| } catch (IOException | InterruptedException e) { | ||
| throw new RuntimeException("Error occurred during receiving response", e); |
There was a problem hiding this comment.
consider creating your custom exception
| List<Character> entityList = characterMapper.toEntityList(responseDto.getResults()); | ||
| characterRepository.saveAll(entityList); | ||
| } catch (IOException | InterruptedException e) { | ||
| throw new RuntimeException("Error occurred during receiving response", e); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.