finished task #171
Closed
finished task #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarakhmen
suggested changes
Jul 7, 2024
.gitignore
Outdated
Comment on lines
21
to
23
| src/main/resources/application.properties | ||
| src/main/resources/liqubase.properties | ||
| test/resources/application.properties |
There was a problem hiding this comment.
why did you add these files to gitignore?
Comment on lines
1
to
9
| [2024/07/02 23:35:23.941, java.exe (PID: 12988, TID: 13520), JavaEnvironment.cpp:502 (JavaEnvironment::detect)] | ||
| TRACE: Entering JavaEnvironment::detect | ||
| [2024/07/02 23:35:23.952, java.exe (PID: 12988, TID: 13520), JavaEnvironment.cpp:519 (JavaEnvironment::detect)] | ||
| TRACE: Installed Java detected: version=; arch=64; productCode={701CE19D-1741-5258-9CD3-D5DDD1A6DEDE}; type=1 | ||
| [2024/07/02 23:35:23.952, java.exe (PID: 12988, TID: 13520), JavaEnvironment.cpp:135 (`anonymous-namespace'::detectHomeDir)] | ||
| TRACE: Find home dir of {701CE19D-1741-5258-9CD3-D5DDD1A6DEDE} Java installation | ||
| [2024/07/02 23:35:23.954, java.exe (PID: 12988, TID: 13520), JavaEnvironment.cpp:302 (`anonymous-namespace'::detectFullVersion)] | ||
| TRACE: Detect full version of {701CE19D-1741-5258-9CD3-D5DDD1A6DEDE} Java installation | ||
| [2024/07/02 23:35:23.955, java.exe (PID: 12988, TID: 13520), JavaEnvironment.cpp:213 (`anonymous-namespace'::detectFullVersionFromMsi)] |
There was a problem hiding this comment.
please remove mvm/appdata/local/temp files from git
| @Component | ||
| @AllArgsConstructor | ||
| public class CharactersClientImpl implements CharactersClient { | ||
| private static final String BASE_URL = "https://rickandmortyapi.com/api"; |
There was a problem hiding this comment.
Let's move this url to the config files (application.properties) instead of hardcoding it
okuzan
suggested changes
Jul 9, 2024
| .map(charactersMapper::toDto) | ||
| .toList(); | ||
| } | ||
|
|
Comment on lines
30
to
32
| return charactersRepository.findAllByName(name).stream() | ||
| .map(charactersMapper::toDto) | ||
| .toList(); |
There was a problem hiding this comment.
FYI mapstruct suppports mapping of list to list, you just need to declare it
| @Override | ||
| public CharactersResponseDto getRandomCharacter() { | ||
| Random random = new Random(); | ||
| Long randomId = random.nextLong( |
There was a problem hiding this comment.
make random a class field to avoid recreation per each method invocation
| import lombok.NoArgsConstructor; | ||
|
|
||
| @Entity | ||
| @Data |
sarakhmen
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.