Created API with 2 methods #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Aug 11, 2024
|
|
||
| @Data | ||
| public class CharacterDto { | ||
| @NotBlank |
There was a problem hiding this comment.
Suggested change
| @NotBlank | |
| @NotNull |
| public class CharacterDto { | ||
| @NotBlank | ||
| private Long id; | ||
| @NotBlank |
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; | ||
| @Column(nullable = false, name = "external_id") |
There was a problem hiding this comment.
Suggested change
| @Column(nullable = false, name = "external_id") | |
| @Column(nullable = false, unique = true) |
|
|
||
| @Override | ||
| public String getKey() { | ||
| return "name"; |
| Random random = new Random(); | ||
| Long randomId = random.nextLong(characterRepository.count() - MIN_ID + 1) + MIN_ID; | ||
| Character character = characterRepository.findById(randomId).orElseThrow(() -> | ||
| new CharacterNotFoundException("Can`t find random character in database")); |
There was a problem hiding this comment.
Suggested change
| new CharacterNotFoundException("Can`t find random character in database")); | |
| new EntityNotFoundException("Can`t find random character in database")); |
| characterDtoList.addAll(characterResponseDto.getResults()); | ||
| nextPageUrl = characterResponseDto.getInfo().getNext(); | ||
| } catch (URISyntaxException | IOException | InterruptedException e) { | ||
| throw new FetchingDataException(e, "Can`t fetch data about characters. URL: " |
There was a problem hiding this comment.
Suggested change
| throw new FetchingDataException(e, "Can`t fetch data about characters. URL: " | |
| throw new CharacterExternalLoadException("Can`t fetch data about characters. URL: " + URL, e); |
okuzan
suggested changes
Aug 20, 2024
| name: status | ||
| type: varchar(256) | ||
| constraints: | ||
| nullable: false |
|
|
||
| @Override | ||
| public CharacterDto getRandomCharacter() { | ||
| Random random = new Random(); |
There was a problem hiding this comment.
create one random per class instance, not per each method invocation
| @Override | ||
| public CharacterDto getRandomCharacter() { | ||
| Random random = new Random(); | ||
| Long randomId = random.nextLong(characterRepository.count() - MIN_ID + 1) + MIN_ID; |
There was a problem hiding this comment.
Suggested change
| Long randomId = random.nextLong(characterRepository.count() - MIN_ID + 1) + MIN_ID; | |
| Long randomId = random.nextLong(characterRepository.count() - 1); |
sorry i don't get it
Comment on lines
62
to
65
| return characterRepository.findAll(characterSpecification) | ||
| .stream() | ||
| .map(characterMapper::toDto) | ||
| .toList(); |
There was a problem hiding this comment.
btw you can declare mapping of list to list in mapstruct's interface
Comment on lines
29
to
31
| List<Character> characters = externalCharacterList.stream() | ||
| .map(characterMapper::toModel) | ||
| .toList(); |
| @Service | ||
| @RequiredArgsConstructor | ||
| public class CharacterServiceImpl implements CharacterService { | ||
| public static final int MIN_ID = 1; |
|
|
||
| @Component | ||
| public class NameSpecificationProvider implements SpecificationProvider<Character> { | ||
| public static final String SQL_WILDCARD = "%"; |
There was a problem hiding this comment.
this is not going to change in decades, okay to hardcode :)
or if you want a constant, create a string format with placeholder then
| public Specification<Character> getSpecification(String param) { | ||
| String pattern = SQL_WILDCARD + param + SQL_WILDCARD; | ||
| return (root, query, criteriaBuilder) -> | ||
| criteriaBuilder.like(criteriaBuilder.lower(root.get("name")), |
There was a problem hiding this comment.
Suggested change
| criteriaBuilder.like(criteriaBuilder.lower(root.get("name")), | |
| criteriaBuilder.like(criteriaBuilder.lower(root.get(NAME_KEY)), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.