solution #189
Open
solution #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuzan
suggested changes
Sep 13, 2024
| return new Random().nextLong(characterRepository.count()); | ||
| } | ||
| } | ||
|
|
| } | ||
|
|
||
| private long getRandomId() { | ||
| return new Random().nextLong(characterRepository.count()); |
There was a problem hiding this comment.
make random a private final class field to avoid needless recreation
| private final CharacterService characterService; | ||
|
|
||
| @Operation(summary = "Get one random character") | ||
| @GetMapping("/randomly") |
There was a problem hiding this comment.
Suggested change
| @GetMapping("/randomly") | |
| @GetMapping("/random") |
makes more sense for RESTful naming
Comment on lines
27
to
28
| @GetMapping("/search") | ||
| public List<CharacterEntity> searchByName(String name) { |
There was a problem hiding this comment.
Suggested change
| @GetMapping("/search") | |
| public List<CharacterEntity> searchByName(String name) { | |
| @GetMapping | |
| public List<CharacterEntity> searchByName(String name) { |
make name a request parameter
liliia-ponomarenko
approved these changes
Sep 17, 2024
| <configuration> | ||
| <configLocation>${maven.checkstyle.plugin.configLocation}</configLocation> | ||
| <consoleOutput>true</consoleOutput> | ||
| <sourceDirectories>src/main/java/mate/academy/rickandmorty/mapper/CharacterMapper.java</sourceDirectories> |
There was a problem hiding this comment.
Why do you apply checkstyle plugin only to one class? Let's apply it to the src directory;)
|
|
||
| @SpringBootApplication | ||
| public class Application { | ||
|
|
||
| private final CharacterService characterService; | ||
|
|
||
| @Autowired |
There was a problem hiding this comment.
JFYI this annotation is optional ;)
| @Getter | ||
| @Setter | ||
| @Entity | ||
| public class CharacterEntity { |
There was a problem hiding this comment.
Suggested change
| public class CharacterEntity { | |
| public class Character { |
| url = dataDto.getInfo().getNext(); | ||
| } | ||
| } catch (IOException | InterruptedException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Let's add an informative message ;)
| spring.jpa.hibernate.ddl-auto=create-drop | ||
| spring.jpa.show-sql=true | ||
| spring.jpa.open-in-view=false | ||
|
|
There was a problem hiding this comment.
Suggested change
Leave only one empty line at the end of the file ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.