Jv rick and morty impl #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoienko
suggested changes
Sep 25, 2024
| public class Application { | ||
| @RequiredArgsConstructor | ||
| public class Application implements CommandLineRunner { | ||
| private static final String RICK_AND_MORTY_API_CHARACTER_URL = "https://rickandmortyapi.com/api/character"; |
There was a problem hiding this comment.
This parameter should be configurable (in application properties), not hardcoded
Comment on lines
2
to
3
| spring.datasource.username=root | ||
| spring.datasource.password=henghfdf |
|
|
||
| spring.jpa.hibernate.ddl-auto=validate | ||
| spring.jpa.show-sql=true | ||
| spring.jpa.open-in-view=false |
There was a problem hiding this comment.
May you explain me why is it matter?
Comment on lines
1
to
5
| E:\Java_projects\jv-rick-and-morty\src\main\java\mate\academy\rickandmorty\dto\external\CharacterFullResponseDto.java | ||
| E:\Java_projects\jv-rick-and-morty\src\main\java\mate\academy\rickandmorty\dto\external\CharacterResponseDto.java | ||
| E:\Java_projects\jv-rick-and-morty\src\main\java\mate\academy\rickandmorty\dto\external\CharacterMetadataDto.java | ||
| E:\Java_projects\jv-rick-and-morty\src\main\java\mate\academy\rickandmorty\dto\internal\CharacterSearchParametersDto.java | ||
| E:\Java_projects\jv-rick-and-morty\src\main\java\mate\academy\rickandmorty\controler\CharacterController.java |
There was a problem hiding this comment.
Are you sure that this file should be on git?
Comment on lines
3
to
8
| mate\academy\rickandmorty\models\Character.class | ||
| mate\academy\rickandmorty\dto\internal\CharacterDto.class | ||
| mate\academy\rickandmorty\external\api\service\impl\ExternalCharacterServiceImpl.class | ||
| mate\academy\rickandmorty\repository\CharacterRepository.class | ||
| mate\academy\rickandmorty\dto\external\CharacterResponseDto.class | ||
| mate\academy\rickandmorty\external\api\service\ExternalCharacterService.class |
There was a problem hiding this comment.
Are you sure that this file should be on git?
| package mate.academy.rickandmorty.external.api.service; | ||
|
|
||
| public interface GetClient<T> { | ||
| T getDtoFromApi(String url); |
There was a problem hiding this comment.
Suggested change
| T getDtoFromApi(String url); | |
| dto.... getDtoFromApi(String url); |
| public class Application { | ||
| @RequiredArgsConstructor | ||
| public class Application implements CommandLineRunner { | ||
| private static final String RICK_AND_MORTY_API_CHARACTER_URL = "https://rickandmortyapi.com/api/character"; |
There was a problem hiding this comment.
Also this url can be moved to client class
| } | ||
|
|
||
| while (true) { | ||
| fullResponseDto.getResults().forEach(externalCharacterService::saveOrUpdate); |
There was a problem hiding this comment.
In current implementation you will make N requests to DB to save N characters
|
|
||
| public interface CharacterRepository extends JpaRepository<Character,Long>, | ||
| JpaSpecificationExecutor<Character> { | ||
| List<Character> findByExternalId(String externalId); |
| return; | ||
| } | ||
|
|
||
| characterMapper.updateCharacterFromResponseDto(characterResponseDto, character); |
There was a problem hiding this comment.
Suggested change
| characterMapper.updateCharacterFromResponseDto(characterResponseDto, character); | |
| Character updatedCharacter = characterMapper.toCharacter(characterResponseDto); | |
| updatedCharacter.setId(existingCharacter.getId) | |
Elena-Bruyako
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.