Solution #200
Open
Solution #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
George-Khomiak
suggested changes
Oct 27, 2024
| return characterService.getRandomCharacter(); | ||
| } | ||
|
|
||
| @GetMapping("/search") |
There was a problem hiding this comment.
@GetMapping
REST is rather resource oriented
| @GetMapping("/random") | ||
| @Operation(summary = "Get a random character", | ||
| description = "Returns a random character from the database.") | ||
| public Optional<Character> getRandomCharacter() { |
There was a problem hiding this comment.
Controllers should work with DTO objects, not with model. Create a response DTO for this endpoint
| @GetMapping("/search") | ||
| @Operation(summary = "Search characters by name", | ||
| description = "Returns a list of characters whose name contains the specified word.") | ||
| public List<Character> searchCharactersByName(@RequestParam String word) { |
There was a problem hiding this comment.
Same here, return list of DTO responses
|
|
||
| @Getter | ||
| @Setter | ||
| public class RickAndMortyResponse { |
There was a problem hiding this comment.
This class name is just the name of whole app, it's not clear why RickAndMorty fetches all characters, it's more like CharacterListDto or something like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.