First Attempt #201
First Attempt #201
Conversation
src/main/java/mate/academy/rickandmorty/controller/CharacterController.java
Outdated
Show resolved
Hide resolved
src/main/java/mate/academy/rickandmorty/controller/CharacterController.java
Outdated
Show resolved
Hide resolved
src/main/java/mate/academy/rickandmorty/controller/CharacterController.java
Outdated
Show resolved
Hide resolved
Empty line removed
|
|
||
| @RequiredArgsConstructor | ||
| @RestController | ||
| @RequestMapping(value = "/character") |
There was a problem hiding this comment.
For API design consistency, it would be better to use a plural form '/characters' instead of '/character'.
| public class CharacterController { | ||
| private final CharacterService characterService; | ||
|
|
||
| @GetMapping |
There was a problem hiding this comment.
The method 'getRandomCharacter' does not have any explicit path. Consider adding an explicit path like '/random' to make it clear this endpoint is for getting a random character.
| List<Character> characters = characterMapper.toModelList(characterDtoList); | ||
| characterRepository.saveAll(characters); | ||
| } catch (IOException | InterruptedException e) { | ||
| throw new EntityNotFoundException("Can't access results from external API", e); |
There was a problem hiding this comment.
EntityNotFoundException is not the appropriate exception to throw when there is an error connecting to the external API. Consider creating a custom exception to handle this scenario.
| @RequiredArgsConstructor | ||
| public class CharacterInitializer { | ||
| @Value("${api.url}") | ||
| private String apiUrl; |
There was a problem hiding this comment.
The 'apiUrl' field should be final. Since we are injecting value from the property file, it should not be changed during runtime.
| @NoArgsConstructor | ||
| @Table(name = "results") | ||
|
|
||
| public class Character { |
There was a problem hiding this comment.
The class 'Character' might conflict with 'java.lang.Character'. Consider renaming your class to something more specific like 'RickAndMortyCharacter'.
No description provided.