Solution #202
Open
Solution #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mapper doesn't work with < sourceDirectories > src < / sourceDirectories >) in pom.xml |
|
Not sure about solution, give some edvice ;) |
JJJazl
suggested changes
Oct 31, 2024
| import org.springframework.web.bind.annotation.RequestMapping; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @Tag(name = "Rick&MortyApi", description = "") |
Comment on lines
20
to
22
| @Operation(summary = "Add random hero", description = """ | ||
| The request randomly generates a wiki about one character in | ||
| the universe the animated series Rick & Morty.""") |
There was a problem hiding this comment.
- Does this endpoint add a random hero or return a random one?
Comment on lines
33
to
36
| @GetMapping("/find") | ||
| List<InternalHeroDto> heroesByName(String name) { | ||
| return rickAndMortyService.findByName(name); | ||
| } |
There was a problem hiding this comment.
- You don't use a @PathVariable or @RequestParam, where do you get parameter "name" from?)
Suggested change
| @GetMapping("/find") | |
| List<InternalHeroDto> heroesByName(String name) { | |
| return rickAndMortyService.findByName(name); | |
| } | |
| @GetMapping | |
| List<InternalHeroDto> getCharacterByName(@RequestParam String name) { | |
| return rickAndMortyService.findByName(name); | |
| } |
| @Operation(summary = "Add random hero", description = """ | ||
| The request randomly generates a wiki about one character in | ||
| the universe the animated series Rick & Morty.""") | ||
| @GetMapping("/get") |
There was a problem hiding this comment.
Suggested change
| @GetMapping("/get") | |
| @GetMapping("/random") |
Comment on lines
24
to
26
| public InternalHeroDto rickAndMorty() { | ||
| return rickAndMortyService.getRandomCharacter(); | ||
| } |
There was a problem hiding this comment.
You use 2 different names: hero and character for the same thing through all your project. Please, stick to one of them, because it can be confusing
|
|
||
| @Override | ||
| public ExternalHeroDto getRandomHero(int randomNumber) { | ||
| HttpClient httpClient = HttpClient.newHttpClient(); |
| return objectMapper | ||
| .readValue(response.body(), ExternalHeroDto.class); | ||
| } catch (IOException | InterruptedException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Please add an informative error message
Comment on lines
46
to
47
| return objectMapper | ||
| .readValue(response.body(), ExternalHeroResponseDto.class).result(); |
There was a problem hiding this comment.
Suggested change
| return objectMapper | |
| .readValue(response.body(), ExternalHeroResponseDto.class).result(); | |
| return objectMapper | |
| .readValue(response.body(), ExternalHeroResponseDto.class) | |
| .result(); |
Comment on lines
23
to
24
| ExternalHeroDto randomHero = rickAndMortyClient | ||
| .getRandomHero(new Random().nextInt(API_COUNT_HEROES)); |
Comment on lines
31
to
38
| return rickAndMortyClient | ||
| .findHeroesByName(name).stream() | ||
| .map(e -> { | ||
| Hero entity = heroMapper.toEntity(e); | ||
| return heroMapper.toDto(heroRepository.save(entity)); | ||
| }) | ||
| .toList(); | ||
| } |
There was a problem hiding this comment.
You don't need always call rickAndMortyClient.findHeroesByName and perform a HTTP call + save the same values in DB (if name is repeated), instead you can load this values from DB
Elena-Bruyako
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.