Completed Rick and Morty task #208
Conversation
There was a problem hiding this comment.
Your code is well-structured and meets the core requirements of the task! 🎉 The implementation is robust, with comprehensive tests and proper use of Spring and Lombok annotations. The only minor issues are the redundant mapping in CharacterMapper and the restrictive regex in CharacterController. These don't impact functionality but could be improved for clarity and flexibility. Keep up the great work, and consider these enhancements for future iterations! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| public List<CharacterResponseDto> searchCharacterByName(@RequestParam String name) { | ||
| if (!name.matches("[a-zA-Z]+")) { |
There was a problem hiding this comment.
The regex [a-zA-Z]+ will only match names consisting entirely of alphabetic characters without spaces or special characters. If the intention is to allow names with spaces or other characters, consider updating the regex accordingly.
|
|
||
| @Mapper(componentModel = "spring") | ||
| public interface CharacterMapper { | ||
| @Mapping(source = "externalId", target = "externalId") |
There was a problem hiding this comment.
The mapping @Mapping(source = "externalId", target = "externalId") is redundant because the field names are the same in both the source and target. MapStruct automatically maps fields with the same name, so this line can be removed.
No description provided.