rick and morty solution #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanderfuck
suggested changes
Oct 29, 2023
pom.xml
Outdated
Comment on lines
84
to
87
| <dependency> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.11.0</version> |
There was a problem hiding this comment.
If it plugin maybe better add to plugins block?
pom.xml
Outdated
Comment on lines
59
to
63
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-maven-plugin</artifactId> | ||
| <version>3.1.2</version> | ||
| </dependency> |
Comment on lines
14
to
16
| logger.info("API Documentation Overview link: http://localhost:8080/api/swagger-ui/index.html#/"); | ||
| logger.info("Get random personality link: " + "http://localhost:8080/api/personalities/random"); | ||
| logger.info("Search link: " + "http://localhost:8080/api/personalities/search?name=Alien&name=Baby"); |
| @Operation(summary = "Search characters.", | ||
| description = "Search characters by params") | ||
| @GetMapping("/search") | ||
| public List<PersonalityDto> search( |
| Female, | ||
| Male, | ||
| Genderless, | ||
| unknown |
Comment on lines
24
to
31
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; | ||
| private Long externalId; | ||
| private String name; | ||
| private Status status; | ||
| private Gender gender; | ||
| @Column(name = "is_deleted", nullable = false) | ||
| private boolean isDeleted = false; |
| public class PersonalitySpecificationBuilderImpl implements SpecificationBuilder<Personality> { | ||
| private static final String NAME_KEY = "name"; | ||
|
|
||
| @Autowired |
|
|
||
| @Component | ||
| public class NameSpecificationProvider implements SpecificationProvider<Personality> { | ||
| private static final String NAME_KEY = "name"; |
| ) { | ||
| final Specification<Personality> personalitySpecification | ||
| = personalitySpecificationBuilder.build(params); | ||
| return personalityRepository.findAll(personalitySpecification,pageable) |
There was a problem hiding this comment.
(personalitySpecification,pageable) - Use Ctrl + Alt+ L before you commit code
Rommelua
approved these changes
Oct 29, 2023
| import org.springframework.boot.SpringApplication; | ||
| import org.springframework.boot.autoconfigure.SpringBootApplication; | ||
|
|
||
| @SpringBootApplication | ||
| public class Application { | ||
| private static final Logger logger = LogManager.getLogger(Application.class); |
There was a problem hiding this comment.
Suggested change
| private static final Logger logger = LogManager.getLogger(Application.class); |
Comment on lines
+7
to
+9
| public class CharacterDto { | ||
|
|
||
| private Long id; |
There was a problem hiding this comment.
Suggested change
| public class CharacterDto { | |
| private Long id; | |
| public class CharacterDto { | |
| private Long id; |
| characterDtos.addAll(rickAndMortyResponseDto.getResults()); | ||
| amountPages = rickAndMortyResponseDto.getInfo().getPages(); | ||
| } catch (IOException | InterruptedException e) { | ||
| e.printStackTrace(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.