Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the project according to the requirements of the task, bu…jjj #37

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

0-zagar-0
Copy link

…t made some methods so that they can be used for other data from the Rick and Morty service

…t made some methods so that they can be used for other data from the Rick and Morty service
Copy link

@Ivan95kos Ivan95kos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix all checks
Знімок екрана 2023-11-03 о 16 49 34

@0-zagar-0 0-zagar-0 closed this Nov 3, 2023
@0-zagar-0 0-zagar-0 deleted the hw-rick-and-morty branch November 3, 2023 19:35
@0-zagar-0 0-zagar-0 changed the title Implemented the project according to the requirements of the task, bu… Implemented the project according to the requirements of the task, bu…jjj Nov 7, 2023
@0-zagar-0 0-zagar-0 restored the hw-rick-and-morty branch November 7, 2023 20:49
@0-zagar-0 0-zagar-0 reopened this Nov 7, 2023
@0-zagar-0 0-zagar-0 requested a review from Ivan95kos November 7, 2023 21:04
@@ -0,0 +1,11 @@
package mate.academy.rickandmorty.service;

public interface ResourceService<R, C, S> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this interface?
image

…hods so as to call the external API once and extract all the data from itÐ
@0-zagar-0 0-zagar-0 requested a review from Rommelua November 8, 2023 22:39

@Service
@RequiredArgsConstructor
// R - resource data page

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// R - resource data page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants