Rick and Morty First Commit #43

romaxa11 · 2023-11-04T18:09:15Z

No description provided.

sokimaaa · 2023-11-04T18:46:44Z

pom.xml

+		<dependency>
+			<groupId>com.mysql</groupId>
+			<artifactId>mysql-connector-j</artifactId>
+			<version>8.1.0</version>


let spring to manage version

Suggested change

<version>8.1.0</version>

sokimaaa · 2023-11-04T18:48:20Z

src/main/java/mate/academy/rickandmorty/Application.java

+    private static RickAndMortyClient rickAndMortyClient;
+    private static CharacterService characterService;
+
+    @Autowired
+    public Application(CharacterService service, RickAndMortyClient client) {
+        Application.rickAndMortyClient = client;
+        Application.characterService = service;
+    }


Application is responsible for booting your app.
Not for the characterService.saveAll(characters);
SRP violates here.

Consider using CommanLineRunner or ApplicationRunner.

Suggested change

private static RickAndMortyClient rickAndMortyClient;

private static CharacterService characterService;

@Autowired

public Application(CharacterService service, RickAndMortyClient client) {

Application.rickAndMortyClient = client;

Application.characterService = service;

}

sokimaaa · 2023-11-04T18:48:55Z

src/main/java/mate/academy/rickandmorty/controller/CharacterController.java

+
+    @Operation(summary = "Get random character",
+            description = "Get a random characters from Rick and Morty world")
+    @GetMapping("/random")


REST URI convention violates here.

Suggested change

@GetMapping("/random")

@GetMapping

sokimaaa · 2023-11-04T18:49:41Z

src/main/java/mate/academy/rickandmorty/controller/CharacterController.java

+
+    @Operation(summary = "Search characters",
+            description = "Search characters by name")
+    @GetMapping("/search")


Recall the REST URI convention.

Suggested change

@GetMapping("/search")

@GetMapping

sokimaaa · 2023-11-04T18:50:17Z

src/main/java/mate/academy/rickandmorty/repository/CharacterRepository.java

+import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.stereotype.Repository;
+
+@Repository


@repository is redundant here.

Suggested change

@Repository

sokimaaa · 2023-11-04T18:51:22Z

src/main/java/mate/academy/rickandmorty/service/RickAndMortyClient.java

+    private final ObjectMapper objectMapper;
+
+    public List<CharacterResponseDto> getCharacters() {
+        HttpClient httpClient = HttpClient.newHttpClient();


Make HttpClient the spring bean.
It shouldnt be created every method invokation.

Suggested change

HttpClient httpClient = HttpClient.newHttpClient();

HttpClient httpClient = HttpClient.newHttpClient();

sokimaaa · 2023-11-04T18:51:47Z

src/main/java/mate/academy/rickandmorty/service/RickAndMortyClient.java

+                    .readValue(response.body(), ListCharacterDto.class);
+            return listCharacterDto.getResults();
+        } catch (IOException | InterruptedException e) {
+            throw new RuntimeException(e);


Add method description here.

Suggested change

throw new RuntimeException(e);

throw new RuntimeException(e);

sokimaaa · 2023-11-04T18:52:19Z

src/main/java/mate/academy/rickandmorty/service/impl/CharacterServiceImpl.java

+@Service
+public class CharacterServiceImpl implements CharacterService {
+    private int listSize;
+    private final Random random = new Random();


We are using spring, so such instantiations is bad practice.
COnsider making random the spring bean.

Suggested change

private final Random random = new Random();

private final Random random = new Random();

sokimaaa · 2023-11-04T18:52:57Z

src/main/resources/application.properties

+spring.datasource.username=root
+spring.datasource.password=Romaxa051979
+#spring.datasource.driver-class-name=com.mysql.cj.jdbc.Driver
+spring.jpa.database-platform=org.hibernate.dialect.MySQLDialect


Is it required property? if not should be removed

Suggested change

spring.jpa.database-platform=org.hibernate.dialect.MySQLDialect

spring.jpa.database-platform=org.hibernate.dialect.MySQLDialect

sokimaaa · 2023-11-04T18:53:43Z

src/test/java/mate/academy/rickandmorty/ApplicationTests.java

@@ -1,13 +1,8 @@
 package mate.academy.rickandmorty;

-import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;

 @SpringBootTest
 class ApplicationTests {


empty class should be removed.

or write the tests.

kerrrusha

almost good

kerrrusha · 2023-11-05T11:51:23Z

src/main/java/mate/academy/rickandmorty/Application.java

+
+    @Bean
+    public CommandLineRunner commandLineRunnerBean() {
+


Suggested change

kerrrusha · 2023-11-05T11:55:22Z

src/main/java/mate/academy/rickandmorty/service/impl/RandomUtil.java

+import org.springframework.context.annotation.Configuration;
+
+@Configuration
+public class RandomUtil {


Suggested change

public class RandomUtil {

public class RandomConfiguration {

kerrrusha · 2023-11-05T11:55:33Z

src/main/java/mate/academy/rickandmorty/service/impl/RandomUtil.java

+    Random util() {
+        return new Random();
+    }


Suggested change

Random util() {

return new Random();

}

public Random random() {

return new Random();

}

kerrrusha · 2023-11-05T11:55:59Z

src/test/java/mate/academy/rickandmorty/ApplicationTests.java

@@ -1,13 +1,8 @@
 package mate.academy.rickandmorty;

-import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;

 @SpringBootTest
 class ApplicationTests {


romaxa11 added 2 commits November 4, 2023 20:07

Rick and Morty First Commit

8499259

Rick and Morty Second Commit

e1e22e6

sokimaaa suggested changes Nov 4, 2023

View reviewed changes

Rick and Morty Third Commit

1d70d7c

romaxa11 requested a review from sokimaaa November 5, 2023 07:41

kerrrusha approved these changes Nov 5, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rick and Morty First Commit #43

Rick and Morty First Commit #43

romaxa11 commented Nov 4, 2023

sokimaaa Nov 4, 2023

sokimaaa Nov 4, 2023

sokimaaa Nov 4, 2023

sokimaaa Nov 4, 2023

sokimaaa Nov 4, 2023

sokimaaa Nov 4, 2023

sokimaaa Nov 4, 2023

sokimaaa Nov 4, 2023

sokimaaa Nov 4, 2023

sokimaaa Nov 4, 2023

kerrrusha Nov 5, 2023

kerrrusha left a comment

kerrrusha Nov 5, 2023

kerrrusha Nov 5, 2023

kerrrusha Nov 5, 2023

kerrrusha Nov 5, 2023

	HttpClient httpClient = HttpClient.newHttpClient();
	HttpClient httpClient = HttpClient.newHttpClient();

	throw new RuntimeException(e);
	throw new RuntimeException(e);

	private final Random random = new Random();
	private final Random random = new Random();

	spring.jpa.database-platform=org.hibernate.dialect.MySQLDialect
	spring.jpa.database-platform=org.hibernate.dialect.MySQLDialect

Rick and Morty First Commit #43

Are you sure you want to change the base?

Rick and Morty First Commit #43

Conversation

romaxa11 commented Nov 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kerrrusha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment