Added working solution #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-hoienko
suggested changes
Nov 6, 2023
| .get("pages") | ||
| .toString(), Long.class); | ||
| for (int i = 1; i <= pages; i++) { | ||
| HttpRequest request = HttpRequest.newBuilder() |
| private final CharacterMapper characterMapper; | ||
| private final CharacterRepository characterRepository; | ||
|
|
||
| public void fetchDataFromApi() { |
There was a problem hiding this comment.
too much responsibilities for one method, I suggest to introduce method (maybe class) which will be responsible for making request (for example lets name it makeRequest(url) and another one which responsibility will be to call makeRequest and collect responses. Maybe makes sence to create method readInitialResponse and readCharacterResponse for parsing raw data to objects
| return characterMapper.toDto(characterRepository | ||
| .findById(random.nextLong(characterRepository | ||
| .findAll().size())).orElseThrow(() | ||
| -> new RuntimeException("Entity was not found"))); |
There was a problem hiding this comment.
It is bad practice to throw general exception, better to throw NotFoundException or something like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.