Implemented task #49
Closed
Implemented task #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olekskov
suggested changes
Nov 7, 2023
|
|
||
| @Tag(name = "Rick and Morty API") | ||
| @RestController | ||
| @RequestMapping("/api") |
There was a problem hiding this comment.
i'd expand path in order to be able to add other endpoints later
Suggested change
| @RequestMapping("/api") | |
| @RequestMapping("/api/characters") | |
Comment on lines
9
to
15
| long count(); | ||
|
|
||
| Character save(Character character); | ||
|
|
||
| List<Character> findAll(); | ||
|
|
||
| Optional<Character> findById(Long id); |
There was a problem hiding this comment.
these methods are present by default in JpaRepository, no need to duplicate
Suggested change
| long count(); | |
| Character save(Character character); | |
| List<Character> findAll(); | |
| Optional<Character> findById(Long id); |
Comment on lines
20
to
24
| @PostConstruct | ||
| private void init() { | ||
| List<Character> characters = client.getCharacters(); | ||
| repository.saveAll(characters); | ||
| } |
There was a problem hiding this comment.
Please move method to CharacterClientImpl
This service mainly works to process our users' requests and initialization is logically out of this scope
Suggested change
| @PostConstruct | |
| private void init() { | |
| List<Character> characters = client.getCharacters(); | |
| repository.saveAll(characters); | |
| } |
Comment on lines
45
to
46
| character.setInternalId(null); | ||
| return repository.save(character); |
There was a problem hiding this comment.
Cannot understand why we reset id and call save for character we just retrieved from DB
Comment on lines
27
to
39
| public List<Character> getAll() { | ||
| return repository.findAll(); | ||
| } | ||
|
|
||
| @Override | ||
| public List<CharacterDto> getCharactersByName(String name) { | ||
| List<Character> characters = repository.findByNameContaining(name); | ||
| List<CharacterDto> characterDtos = mapper.map(characters); | ||
| return characterDtos; | ||
| } | ||
|
|
||
| @Override | ||
| public Character saveRandomCharacter() { |
There was a problem hiding this comment.
you should unify if you service returns DTOs or models
Comment on lines
23
to
35
| public List<Character> getCharacters() { | ||
| return characterService.getAll(); | ||
| } | ||
|
|
||
| @Operation(summary = "Find characters by specific name.") | ||
| @GetMapping("/search") | ||
| public List<CharacterDto> getCharactersByName(String name) { | ||
| return characterService.getCharactersByName(name); | ||
| } | ||
|
|
||
| @Operation(summary = "Generate and save random existing character.") | ||
| @GetMapping("/random") | ||
| public Character saveRandomCharacter() { |
There was a problem hiding this comment.
please use dtos and hide internal implementation of classes
Rommelua
approved these changes
Nov 8, 2023
Comment on lines
+20
to
+23
| @Operation(summary = "Get all available characters.") | ||
| @GetMapping | ||
| public List<CharacterDto> getCharacters() { | ||
| return characterService.getAll(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.