implemented rick and morty wiki #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevheniisynytsia
suggested changes
Nov 15, 2023
| private final CharacterRepository characterRepository; | ||
| private final CharacterMapper characterMapper; | ||
| private final RickAndMortyClient rickAndMortyClient; | ||
| @Value("${rick-and-morty.get.characters.url}") |
There was a problem hiding this comment.
Suggested change
| @Value("${rick-and-morty.get.characters.url}") | |
| @Value("${rickAndMorty.characters.url}") |
|
|
||
| @PostConstruct | ||
| public void init() { | ||
| String url = getCharactersUrl; |
There was a problem hiding this comment.
url is redundant, just use the getCharactersUrl variable
| spring.jpa.hibernate.ddl-auto=create-drop | ||
| spring.jpa.show-sql=true | ||
|
|
||
| rick-and-morty.get.characters.url=https://rickandmortyapi.com/api/character |
There was a problem hiding this comment.
Suggested change
| rick-and-morty.get.characters.url=https://rickandmortyapi.com/api/character | |
| rickAndMorty.characters.url=https://rickandmortyapi.com/api/character |
at least get is odd. rickAndMorty or rick-and-morty or rick.and.morty is up to you
| private final CharacterMapper characterMapper; | ||
| private final RickAndMortyClient rickAndMortyClient; | ||
| @Value("${rick-and-morty.characters.url}") | ||
| private String getCharactersUrl; |
There was a problem hiding this comment.
sorry didn't pay attention to it during the first review
getCharactersUrl means action, so it's more like a method name. Variables should be nouns, like charactersUrl
yevheniisynytsia
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.